Skip to content

Create feature flag for Gitaly pack object hook

Sean McGivern requested to merge create-gitaly-pack-object-hooks-feature-flag into master

What does this MR do?

This exists to register the flag on the Rails side. The flag in Gitaly was implemented by gitaly!3038 (merged).

To test this locally, first try cloning a repo without enabling this flag. $GDK_ROOT/log/praefect-gitaly-0/gitaly_hooks.log should be empty (unless you have any other custom hooks).

Then, enable the flag with bundle exec rails r 'Feature.enable("gitaly_upload_pack_gitaly_hooks")'. Cloning a repo will now add a line like this:

time="2021-02-02T11:31:35Z" level=info msg="local git command" args="[pack-objects --revs --thin --stdout --progress --delta-base-offset]"

See gitlab-com/gl-infra/scalability#807 (closed).

Edited by Sean McGivern

Merge request reports