Skip to content

Resolve "Follow-up from "Add click tracking to in product marketing email campaigns""

Alex Buijs requested to merge 300557-follow-up-from-add-click-tracking-to-in-product-marketing-email-campaigns into master

What does this MR do?

The following discussions from !52723 (merged) should be addressed:

  • @arturoherrero started a discussion:

    Non-blocking: If we modify Namespaces::InProductMarketingEmailsService::INTERVAL_DAYS this test will fail, eg. adding a new entry to the array. @alexbuijs What do you think about that?

  • @arturoherrero started a discussion:

    Non-blocking: @alexbuijs Shall we extract this matcher to spec/support/matchers/ directory so we can re-use it?

Related: #300557 (closed)

Edited by Alex Buijs

Merge request reports