Skip to content

Replace find with findComponent in spec/admin

What does this MR do?

Issue #295679 (closed)

  • Update docs with new recommendation.
  • Update folders spec/admin and ee/spec/admin
  • Some occurrences of find could not be converted to findComponent even though they are used to find Vue components. This is because the parent wrapper was a DOM element and not a Vue component (for example, when used like wrapper.find('[data-test-id]').find(GlButton)).

Note

I used the following regex to find instances find(\([^'")]*\)) and replaced that with findComponent$1.

Screenshots (strongly suggested)

N.A.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong

Merge request reports

Loading