Fix full screen mode for comments in merge request changes view
What does this MR do?
Entering full screen mode when writing a comment in a merge request's changes view broke the UI (see #294156 (closed)).
This MR addresses this issue by removing a too low z-index on an ancestor of the comment textarea element.
The original z-index setting was introduced with ce91c326 and changed with d2fd6bd5 and 56f84a34. Considering the modification history and the current layout, I think that this setting is no longer required (otherwise we could also set it to a value > 1000, which is the z-index of the navbar).
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #294156 (closed)