Resolve "Split out recursive namespace traversal"
What does this MR do?
Moved the set of Namespace methods that deal with traversal in to their own module.
This move is being made as part of a larger effort to improve performance of namespace queries by replacing recursive queries with linear queries.
There is some more general information in the epic at &5296 (closed)
The work has been created under a new module to satisfy this new rubocop rule !51236 (merged)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Related to #300519 (closed)
Merge request reports
Activity
changed milestone to %13.9
added 370 commits
-
fe4faf2c...8b909061 - 369 commits from branch
master
- 93217535 - Move Namespace traversal queries to module
-
fe4faf2c...8b909061 - 369 commits from branch
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 52999 "Resolve "Split out recursive namespace traversal""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 52999 "Resolve "Split out recursive namespace traversal""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Aishwarya Subramanian ( @asubramanian1
) (UTC-6, 14 hours behind@alexpooley
)Igor Drozdov ( @igor.drozdov
) (UTC+3, 5 hours behind@alexpooley
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added typemaintenance label
added typefeature label
- Resolved by Alex Kalderimis
@pshutsin Can you please perform first review of this work?
🙇
requested review from @pshutsin
added workflowin review label and removed workflowin dev label
requested review from @alexkalderimis
removed review request for @pshutsin
mentioned in merge request !52854 (merged)
mentioned in issue #301142 (closed)
- Resolved by Alex Kalderimis
- Resolved by Alex Kalderimis
Thanks @alexpooley - this looks great. Just one comment about where we should put this new, and surprisingly general module.
Back to you!
🎾
assigned to @alexkalderimis
added 840 commits
-
2f2fc07c...e855f37f - 839 commits from branch
master
- 3d08463d - Move Namespace traversal queries to module
-
2f2fc07c...e855f37f - 839 commits from branch
enabled an automatic merge when the pipeline for 665a3ac0 succeeds
mentioned in commit 5c538ae5
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowstaging label and removed workflowcanary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #300519 (closed)
added releasedcandidate label
mentioned in issue #323918 (closed)
mentioned in issue #324746 (closed)
mentioned in issue #324747 (closed)
mentioned in issue #324748 (closed)
mentioned in issue #324749 (closed)
mentioned in issue #324750 (closed)
removed typefeature label