Update the database when moving repos between identical storages
What does this MR do?
Fixes #294126 (closed)
Skips replicating/removing repositories to allow admins to move projects between identical storages.
Previously when any two storages were either configured identically (this is the case for the gitlab staging environment) or when two separate gitalys are configured with the same physical storage, admins could not update the projects repository storage. This was because of a safety check to prevent dataloss. Since we know these storages are identical based on https://gitlab.com/gitlab-org/gitaly/blob/master/internal/storage/metadata.go#L38 it should be safe to simply update the database without actually replicating the repositories.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team