Skip to content

Increase ActionCable retry interval

Heinrich Lee Yu requested to merge increase-actioncable-reconnect-interval into master

What does this MR do?

This updates the default max interval defined in https://github.com/rails/rails/blob/v6.0.3.4/actioncable/app/assets/javascripts/action_cable.js#L146-L150 from 30 seconds to 5 minutes.

This is recommended by the infra team to reduce the reconnect attempts we get in case of an outage.

This has a downside where clients may take longer to get reconnected if they are having internet issues. But this is an experimental feature for now (real-time assignees) and the page would work fine without this anyway so I think it's fine to be a bit on the safe side for now.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports