Skip to content

Update sidebartogglebutton Template

Jannik Lehmann requested to merge jnnkl-validhtml-sidebar into master

What does this MR do?

I threw a couple of GitLab routes into the https://validator.w3.org/ and figured that we have some Issues with our markup being not valid. One of them is our Sidebar containing not allowed elements in an unordered list in the projects template.

See Screenshot attached.

This MR fixes that.

Screenshots (strongly suggested)

before after
Screenshot_2021-02-04_at_12.41.07 Screenshot_2021-02-05_at_20.56.00

Demo Video: 2021-02-05_21-52-06

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jannik Lehmann

Merge request reports