Remove redundant borderless state for CI Icon in MR widget pipeline and Tests tab
requested to merge 299559-remove-add-border-borderless-prop-from-ci-icon-when-used-together into master
What does this MR do?
Remove "borderless" in "MR Widget Pipeline" CI Icon
As having both borderless and .add-border class in the same element
is contradictory, this change removed both properties from the MR widget pipeline CI icon.
The appearance is almost the same, however, now the the circle border comes from the svg, instead of coming from a CSS style, so the border scales with the SVG image.
More details at: #299559 (closed)
Screenshots (strongly suggested)
MR widget pipeline (icon on the left):
| consistent icon look |
|---|
 |
Pipeline MR Widget:
| Before | After |
|---|---|
 |
 |
Pipelines Test tab
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #299559 (closed)
Edited by Miguel Rincon