Fix text limit cop to work with new table helper
What does this MR do?
Update the Migration/AddLimitToTextColumns to work with the create_table_with_constraints helper added in !50309 (merged). The helper was first used here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/migrate/20210111051045_create_dast_profiles.rb#L11 and at that time discovered it didn't play nicely with this cop.
Text columns created in a table using the new helper should now be properly detected and flagged. Eventually, it might make sense to modify the cop further to raise an offense when a standard create_table is used with a text column, since that may be a pattern we want to avoid altogether.
For now, I think it makes sense to take the easier path of fixing the existing cop so we can use the new helper without having to disable anything.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team