Skip to content

Use feature from know_events yml files for checking the features

What does this MR do?

Move the check for feature flag under the HLLRedisCounter module, this way we have a single place where we check the feature flag enabled/disabled

Use default_enabled: :yaml, this allows a single change when we want to enabled by default a feature flag and no other code changes required.

If there is no feature set for the event in know events definition, no feature flag is checked

This would make feature flags for redis hll tracking easier to maintain

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #276948 (closed)

Edited by Alina Mihaila

Merge request reports