Draft: Factor out iteration dropdown and polish the UI/UX of the dropdown.
What does this MR do?
- Refactors
iteration_select.vueto be a reusable component. (it couldn't be used right away in the new boards sidebar because it had contained 'edit' button and other things).
Here is the new component hierarchy:
mount_sidebar.js => 'sidebar_item_iteration_select.vue' => 'iteration_select.vue'
UI fix:
- Make the iteration dropdown consistent with gitlab-ui (resolves #300248 (closed))
- Clears the search box on selecting an iteration item.
- display a loading spinner when any network request is in progress. #300371 (closed).
Spec update
- Use mock apollo client in spec.
Screenshots
| Place | Before | After |
|---|---|---|
| Issue page sidebar |  |
 |
| Issue page sidebar |  |
 |
Demo
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by euko