Skip to content

Global Search - UX Refresh for Sort Button

Zack Cuddy requested to merge 273328-global-search-sort-ux into master

What does this MR do?

Closes #273328 (closed)

This MR resolves a few UX concerns noted in the above issue. Initially I thought to try and adjust the CSS to match GitLab UI but after some consideration I felt that it was better to move to Vue and the GitLab UI components after taking &4532 (closed) into consideration. This avoids the technical debt if the styling of these drop-downs change in Pajamas in the future.

This change also addresses some of the naming concerns from the above issue to be more consistent with other parts of GitLab.

Important Note

The dropdown items vary between Basic and Advanced (Elastic) search. The Rails helpers provide those options as constants to the frontend

Screenshots (strongly suggested)

Before After
Desktop View (1,600px) Desktop_View__Before_ Desktop_View__After_
Mobile View (375px) 375px__Before_ 375px__After_
Basic Search Dropdown Basic_Search__Before_ Basic_Search__After_
Advanced Search Dropdown Advanced_Search__Before_ Advanced_Search__After_

GIF

Functionality

Kapture_2021-01-25_at_12.56.20

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #273328 (closed)

Edited by Zack Cuddy

Merge request reports