Skip to content

Fix N+1 Issue with loading approval rules

What does this MR do?

Adding a pre-load to approval_project_rules and approval_merge_request_rules removes an N+1 issue with loading rules in the MergeRequest#index method

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #276944 (closed)

Edited by Gary Holtz

Merge request reports