Refactor deployment frequency API
What does this MR do?
This MR resolves some ~"technical debt" in the Deployment Frequency facility. Specifically:
- Based on the abstraction guideline,
refactoring the business logic for deployment aggregation. Specifically, introducing
Analytics::Deployments::Frequency::AggregateService
as the SSOT service to process the aggregation. - Defining the SSOT finder to search deployments rows. This prevents the reinvention of wheels from happening.
- Localization on the error messages as it's better to be done for all texts.
- Adjust the license name as it's too broad to define the feature scope. It's renamed to
cd_dora_analytics
fromproject_activity_analytics
.
There are no feature changes are made in this MR, but just a simple refactoring.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda