Skip to content

Allow an alternate incoming email address for GitLab.com

Sean McGivern requested to merge alternate-incoming-mail-address-for-gitlab-com into master

What does this MR do?

Allows incoming email to GitLab.com only to be received at either incoming+*@gitlab.com or incoming+*@incoming.gitlab.com.

We will remove this once it's no longer needed.

Are there points in the code the reviewer needs to double check?

Did I miss anything this time? 😊

The reason I hard-coded this, instead of using the configuration, is that it allows us to change to the new configuration at any time.

If this was a post-deployment patch, there would be a window after each deployment, before patching, where we'd have the 'wrong' code on our Sidekiq workers, and we'd fail to process emails.

Why was this MR needed?

https://about.gitlab.com/2018/03/06/reconfigure-inbound-email-for-gitlab-notification/

Merge request reports