Skip to content

Preset root ancestor when finding labels

Jan Provaznik requested to merge preset_root_for_labels into master

What does this MR do?

Because we search for permissioned labels which all have the same top-level group, we can preset root_ancestor for them before permission check. This optimization saves us extra query to fetch root ancestor (called from group policy).

Related to #299467 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports