Skip to content

Persist code quality payload mr diff

Max Orefice requested to merge mo-introduce-codequality-presenter into master

Ref: #267600 (closed)

This feature will be behind a feature flag called codequality_mr_diff

This is Step #3 toward creating a new codequality report attached to a pipeline.

What does this MR do?

This MR adds persists our codequality data required by the frontend for our feature.

It includes the following items:

  • Creates new CodequalityMrDiff report
  • Adds new Serializer to expose the required data used by the frontend
  • Creates associated entity for it
  • Persists the data as a pipeline artifact

A pipeline artifact is used to persist generated report after pipeline completion.

For example we use it for displaying tested code on a MR diff. We will start using this abstraction for displaying codequality warning on diff/MR.

Why are we doing this?

The grouptesting is currently planning to build up more features with codequality and one of those is to display codequality diff on the MR itself. This will be similar to our current test coverage feature.

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports