File templates fetching refactor [RUN AS-IF-FOSS] [RUN ALL RSPEC]

added 1 commit

534cd904 - Prepare templates fetching code for templates inheritance

	3 Warnings
	This merge request is quite big (more than 774 lines changed), please consider splitting it into multiple merge requests.
	0ce26285: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	Please add a throughput label to this merge request.

2 Messages

This merge request adds or changes files that require a review from the Database team.

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, run the following:

bin/changelog -m 52222 "File templates fetching refactor [RUN AS-IF-FOSS] [RUN ALL RSPEC]"

If you want to create a changelog entry for GitLab EE, run the following instead:

bin/changelog --ee -m 52222 "File templates fetching refactor [RUN AS-IF-FOSS] [RUN ALL RSPEC]"

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

app/finders/license_template_finder.rb
app/finders/template_finder.rb
ee/app/finders/ee/license_template_finder.rb
ee/app/finders/ee/template_finder.rb

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Aakriti Gupta (`@aakriti.gupta`) (UTC+1, 1 hour behind `@acroitor`)	Bob Van Landuyt (`@reprazent`) (UTC+1, 1 hour behind `@acroitor`)
database	Nikola Milojevic (`@nmilojevic1`) (UTC+1, 1 hour behind `@acroitor`)	Adam Hegyi (`@ahegyi`) (UTC+1, 1 hour behind `@acroitor`)
frontend	Jeremy Jackson (`@jejacks0n`) (UTC-7, 9 hours behind `@acroitor`)	Martin Wortschack (`@wortschi`) (UTC+1, 1 hour behind `@acroitor`)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 58acfc19 and 0ce26285

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.08 MB	3.08 MB	-	0.0 %
mainChunk	1.85 MB	1.85 MB	-	0.0 %

Note: We do not have exact data for 58acfc19. So we have used data from: 2e50e7cf.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Read more about how this report works.

Generated by Danger

added 1 commit

e08ffae0 - Prepare templates fetching code for templates inheritance

File templates fetching refactor [RUN AS-IF-FOSS] [RUN ALL RSPEC]

What does this MR do?

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Merge request reports

Activity

Reviewer roulette

Bundle size analysis [beta]

Special assets