Skip to content

Jira Connect app UI polish and improvements

Justin Ho Tuan Duong requested to merge 297685-jira-connect-app-ui-polish into master

What does this MR do?

  • Implements design / copy recommendations from #297685 (closed).
    • Smaller font sizes for headings, changed some text to paragraph.
    • Add GitLab UI button style for "Sign in" button.
    • Standardize spacing between sections.
    • Remove "Google Chrome" as recommended browser since it's not really working.
    • Update link when user is signed in to lead to Jira Connect users page instead of to the profile page.
  • Fixes a bug where the "Add namespace" button is displayed to non-logged in users. Instead, we should show "Sign in to GitLab". This prevents non-logged in users from seeing the "Add namespace" button and modal and trying to "Link" a namespace when it's not really working.

Screenshots (strongly suggested)

Scenario Before After
Without namespaces, not logged in Without_namespaces__not_logged_in_-_Before Without_namespaces__not_logged_in_-_After
Without namespaces, logged in Without_namespaces__logged_in_-_Before Without_namespaces__logged_in_-_After
With namespaces, logged in With_namespaces__logged_in_-_Before With_namespaces__logged_in_-_After
With namespaces, not logged in With_namespaces__not_logged_in_-_Before With_namespaces__not_logged_in_-_After

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong

Merge request reports