Skip to content

Log the project id in `ContainerExpirationPolicies::CleanupContainerRepositoryWorker`

🛩 Context

The ContainerExpirationPolicies::CleanupContainerRepositoryWorker is the main worker responsible of executing cleanup policies.

It is implemented off the limited capacity worker concern. As such, it doesn't the work to do. Instead, it is needs to query the database to fetch a container repository to cleanup.

It is important that we monitor what this worker is actually doing. For that aspect we already have a bunch of "extra" fields that are logged in the "done" message.

We still have a missing piece of information: the project_id. This would help us to filter out the logs per project_id instead of container_repository_id.

🔨 What does this MR do?

  • Add the project_id to the extra log for the "done" message
  • Update the relevant spec.

🔭 Screenshots (strongly suggested)

n / a

🔩 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports