Skip to content

Update dependency @gitlab/eslint-plugin to v7

🤖 GitLab Bot 🤖 requested to merge renovate/major-gitlab-packages into master

This MR contains the following updates:

Package Type Update Change
@gitlab/eslint-plugin devDependencies major 6.0.0 -> 7.0.0

MR created with the help of gitlab-org/frontend/renovate-gitlab-bot

Human-written changes to address breaking changes

The existing violations of the @gitlab/no-runtime-template-compiler rule fall into a few different categories:

  • True violations
    • Explicit template options in Vue component definitions
    • Implicit violations by relying on the mounting element to contain the template, generated by the backend
  • False violations
    • Instantiating a Vue SFC by spreading it into new Vue, e.g.: new Vue({ el, ...SomeVueSFC });
    • EE components which use extends of a CE component, which itself correctly uses an ahead-of-time compiled template
    • Pretty much any file that defines a Vue mixin

The more straight-forward true violations have been fixed and verified as working, although there doesn't seem to be existing unit tests for them.

The aren't many examples of false violations in the codebase, though it's feasible that the lint rule could be improved to not report these in future.

The rule is disabled entirely for specs, since in that context, having a runtime template compiler can be useful.

Addresses gitlab-org/frontend/eslint-plugin#24 (closed), part of &5142.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

  • If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

Edited by 🤖 GitLab Bot 🤖

Merge request reports