Add note about confidential trusted OAuth apps
What does this MR do?
It adds a recommendation to set trusted OAuth applications as confidential.
Trusted OAuth applications do not have the additional step that requires a user to explicitly allow the application to access their account. Non-confidential applications don't require the client_secret to request credentials. This opens the door to abuse and should be discouraged.
Related incident: https://gitlab.com/gitlab-com/gl-security/security-operations/sirt/operations/-/issues/1241
Screenshots (strongly suggested)
This only affects the /admin/applications/new and /admin/applications/:id/edit routes. User OAuth applications don't have the Trusted option.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team