Skip to content

Conditionally render policy alert editor

Alexander Turinske requested to merge 297463-disable-alert-for-no-agent into master

What does this MR do?

Conditionally render policy alert editor

  • check if any agents have been installed and configured
  • show the policy alert picker if an agent has been added, do now show it if no agent has been added
  • create help urls to guide the user
  • Abstract out policy editor data to helper

Screenshots (strongly suggested)

Before After with agent After without agent After with alert but without agent
Screen_Shot_2021-01-19_at_3.43.57_PM Screen_Shot_2021-01-19_at_3.43.57_PM Screen_Shot_2021-01-19_at_3.43.28_PM removed_agent_cannot_add_new_alert

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #297463 (closed)

Edited by Alexander Turinske

Merge request reports