Skip to content

Fix bad call to tracking_label

Doug Stull requested to merge fix-tracking-label-call into master

What does this MR do?

Fixes error when calling tracking_label when Gitlab::Experimentation.active?(:invite_members_new_dropdown) && can_import_members? is true in this partial

Since the experiment is not active yet in production, there is no impact currently as this evaluates to false.

Updated our tracking issue to wait for this MR to be merged before enabling again - https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/291#note_489158165.

Note we are behind a feature flag/experiment here - as is the bug.

Screenshots (strongly suggested)

error is seen locally

Screen_Shot_2021-01-19_at_3.13.11_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Doug Stull

Merge request reports