Set tooltip for disabled buttons in a wrapper
What does this MR do?
This Merge Request fixes a bug with the new Tooltips API where tooltips with disabled buttons don‘t disappear in the blob viewer. This problem arises because BootstrapVue tooltips do not work on disabled elements unlike their Bootstrap counterpart.
To fix this problem, we have to address every case individually. Each disabled button should be wrapped in a span elements that has the tooltip attached.
Screenshots (strongly suggested)
To test this MR changes locally, you have to enable the gl_tooltips feature flag on your local environment. If the bug is fixed, tooltips should not be stuck after the mouse leaves the tooltip’s target.
Delete branch button
URL: http://localhost:3000/h5bp/html5-boilerplate/-/branches
Fork button
testing notes: I recommend replacing unless can_create_fork with unless false in app/views/projects/buttons/_fork.html.haml for easier testing.
Delete group runner
URL: http://localhost:3000/groups/flightjs/-/settings/ci_cd
how to test: To make testing easier, I recommend replacing if runner.belongs_to_more_than_one_project? with if true in app/views/groups/runners/_runner.html.haml
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #292972 (closed)