Skip to content

Add error handling to update member service

What does this MR do?

Related to #217155 (closed)

  • Adds error handling to Members::UpdateService, modify controller and api methods that use this service accordingly.
  • Response now in case of error: http status 422, json: { message: "error message" }.
  • Updates frontend to display error message provided by the backend

Screenshots (strongly suggested)

Desktop

Screen_Shot_2021-01-22_at_9.44.00_AM

Mobile

Screen_Shot_2021-01-22_at_9.44.19_AM

Local testing

  1. Create a group
  2. Navigate to "Group" -> "Members"
  3. Use the form to add a new member
  4. Navigate to "Group" -> "Settings" -> "General" -> "Permissions, LFS, 2FA"
  5. Add a email that does not match the member just added in the "Restrict membership by email domain" field
  6. Navigate to "Group" -> "Members" and try to change the member's role or expiration.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports