Add error handling to update member service
requested to merge 217155-role-can-t-be-changed-for-users-not-meeting-domain-restriction into master
What does this MR do?
Related to #217155 (closed)
- Adds error handling to Members::UpdateService, modify controller and api methods that use this service accordingly.
- Response now in case of error: http status 422, json:
{ message: "error message" }
. - Updates frontend to display error message provided by the backend
Screenshots (strongly suggested)
Desktop
Mobile
Local testing
- Create a group
- Navigate to "Group" -> "Members"
- Use the form to add a new member
- Navigate to "Group" -> "Settings" -> "General" -> "Permissions, LFS, 2FA"
- Add a email that does not match the member just added in the "Restrict membership by email domain" field
- Navigate to "Group" -> "Members" and try to change the member's role or expiration.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman