Skip to content

Support number formatting from user settings

Miguel Rincon requested to merge locale-number-formatting into master

What does this MR do?

Support number formatting from user settings

This MR aims to provide the locale support in numbers, so the utils lib that I mentioned gitlab-org/frontend/rfcs#73 (closed) can be used for us to localize our numbers.

This change checks the current locale in the document to select which locale should be used when formatting numbers. The locale in the document, comes from the user settings.

Note: This MR is currently blocked by gitlab-build-images#53 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Greiling

Merge request reports