Skip to content
Snippets Groups Projects

Support number formatting from user settings

Merged Miguel Rincon requested to merge locale-number-formatting into master
All threads resolved!

What does this MR do?

Support number formatting from user settings

This MR aims to provide the locale support in numbers, so the utils lib that I mentioned gitlab-org/frontend/rfcs#73 (closed) can be used for us to localize our numbers.

This change checks the current locale in the document to select which locale should be used when formatting numbers. The locale in the document, comes from the user settings.

Note: This MR is currently blocked by gitlab-build-images#53 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Greiling

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 3 Warnings
    :warning: Please add a throughput label to this merge request.
    :warning: This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, run the following:

    bin/changelog -m 52002 "Support number formatting from user settings"

    If you want to create a changelog entry for GitLab EE, run the following instead:

    bin/changelog --ee -m 52002 "Support number formatting from user settings"

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    frontend Coung Ngo (@cngo) (UTC+0, 1 hour behind @mrincon) Paul Slaughter (@pslaughter) (UTC-6, 7 hours behind @mrincon)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Miguel Rincon
  • Miguel Rincon changed the description

    changed the description

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 458c0d35 and b9ca7d93

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.07 MB 3.07 MB - 0.0 %
    mainChunk 1.89 MB 1.89 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Setting label grouppipeline authoring based on @mrincon's group.

  • Miguel Rincon marked this merge request as draft

    marked this merge request as draft

  • mentioned in merge request gitlab-build-images!354 (merged)

  • Lukas Eipert mentioned in merge request !52099 (merged)

    mentioned in merge request !52099 (merged)

  • Setting label(s) ~"Category:Pipeline Authoring" devopsverify sectionops based on grouppipeline authoring.

  • added devopsverify sectionops + 1 deleted label

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon added 1053 commits

    added 1053 commits

    Compare with previous version

  • Mike Greiling requested review from @mikegreiling

    requested review from @mikegreiling

  • Mike Greiling approved this merge request

    approved this merge request

  • Mike Greiling marked this merge request as ready

    marked this merge request as ready

  • Mike Greiling resolved all threads

    resolved all threads

  • merged

  • Mike Greiling mentioned in commit 360409e6

    mentioned in commit 360409e6

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading