Support number formatting from user settings
What does this MR do?
Support number formatting from user settings
This MR aims to provide the locale support in numbers, so the utils lib that I mentioned gitlab-org/frontend/rfcs#73 (closed) can be used for us to localize our numbers.
This change checks the current locale in the document to select which locale should be used when formatting numbers. The locale in the document, comes from the user settings.
Note: This MR is currently blocked by gitlab-build-images#53 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added frontend label
3 Warnings Please add a throughput label to this merge request. This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 52002 "Support number formatting from user settings"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 52002 "Support number formatting from user settings"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+0, 1 hour behind@mrincon
)Paul Slaughter ( @pslaughter
) (UTC-6, 7 hours behind@mrincon
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Miguel Rincon
mentioned in issue gitlab-org/frontend/rfcs#73 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 458c0d35 and b9ca7d93
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.07 MB 3.07 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue gitlab-build-images#53 (closed)
Setting label grouppipeline authoring based on
@mrincon
's group.added grouppipeline authoring label
mentioned in merge request gitlab-build-images!354 (merged)
mentioned in merge request !52099 (merged)
Setting label(s) ~"Category:Pipeline Authoring" devopsverify sectionops based on grouppipeline authoring.
added devopsverify sectionops + 1 deleted label
added 1053 commits
-
2295a214...458c0d35 - 1052 commits from branch
master
- b9ca7d93 - Support number formatting from user settings
-
2295a214...458c0d35 - 1052 commits from branch
assigned to @mikegreiling
requested review from @mikegreiling
mentioned in commit 360409e6
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request gitlab-omnibus-builder!173 (merged)
added Category:Pipeline Composition label