Skip to content

API fuzz show alternative message when "body" is not available - bug fix

- requested to merge 284677-api-fuzzing-empty-body-bug-fix into master

What does this MR do?

Original Issue: #284677 (closed) Follow-up to: !50731 (merged)

Bug fix:

"" or empty string is considered falsely, but we want don't want to show the empty body message if it's an empty string. Even though it's a blank string, it's not explicitly an empty body from the server. We only consider "null" or "undefined" to show the empty body message.

Screenshots (strongly suggested)

Before

Screen_Shot_2021-01-25_at_1.27.59_AM

After (when body string is actually blank and set to empty string "")

Screen_Shot_2021-01-25_at_1.27.32_AM

After (body is undefined or null)

body_not_provided

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #284677 (closed)

Edited by -

Merge request reports