Skip to content

Fix the nuget group level API url prefix

David Fernandez requested to merge 36423-fix-nuget-group-api-url into master

🏝 Context

Follow up of !48356 (merged) where we added the NuGet API for Groups.

At that time, the url form for the API main endpoint was: https://gitlab.example.com/api/v4/groups/<your_group_id>/packages/nuget/index.json.

This does not follow what we have for other package managers APIs (see for example, Maven group level API) where we have: https://gitlab.example.com/api/v4/groups/GROUP_ID/-/packages/maven

The difference is that the NuGet url is missing the -/ segment. That might not be much but it has some impact on how the requests are "classified". For example, the API rate limiters uses that information.

For consistency sake, we're going to fix the nuget url.

Related issue: #36423 (closed)

🔍 What does this MR do?

  • Add the -/ section to the nuget group level url.
    • Update the related specs
    • Update the grape path helper function name
  • Changelog not needed as it's a follow up of !48356 (merged) which has one

🎥 Screenshots (strongly suggested)

See !48356 (merged)

👮 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports