Skip to content

Trigger empty state only for missing file case

What does this MR do?

Fix for #297650 (closed)

The problem occurs because there is an API mismatch between the available GraphQL fields the the frontend requests and what's available in the backend. This would normally be ok but...

...in this line the LOAD_FAILURE_UNKNOWN triggers the same error state as if the file cannot be loaded, leading to page fields to disappear.

Note: This change requires the flags ci_pipeline_editor_page to be enabled, so no changelog is included.

Screenshots (strongly suggested)

Even after adding a missing property (fake_field), the editor is shown and the error is handled correctly:

Screen_Shot_2021-01-13_at_10.22.24_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #297650 (closed)

Edited by Miguel Rincon

Merge request reports

Loading