Skip to content

Fix IID collision after import

Alex Kalderimis requested to merge ajk-iid-collision-after-import into master

What does this MR do?

This MR fixes #297362 (closed), which involved the incorrect IID being allocated by safe-find-or-create.

This is handled correctly if we instead call build, validate and save as separate steps.

Screenshots (strongly suggested)

Demonstrating one design from the import, and another added later:

1610550567

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports