Skip to content

Move Danger code from lib/ to tooling/ [RUN ALL RSPEC]

Albert Salim requested to merge caalberts-move-danger-out-of-lib into master

What does this MR do?

Move Danger code from lib/ to tooling/.

  • avoids autoload conflicts when Rails is loaded in development
  • avoids autoloading non-production Danger code in production

Before:

 bundle exec rails c
--------------------------------------------------------------------------------
 Ruby:         ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
 GitLab:       13.8.0-pre (9c2d0a47241) EE
 GitLab Shell: 13.15.0
 PostgreSQL:   11.9
--------------------------------------------------------------------------------
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/title_linting.rb:6: warning: already initialized constant Gitlab::Danger::TitleLinting::DRAFT_REGEX
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/title_linting.rb:6: warning: previous definition of DRAFT_REGEX was here
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage.rb:6: warning: already initialized constant Gitlab::Danger::Weightage::CAPACITY_MULTIPLIER
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage.rb:6: warning: previous definition of CAPACITY_MULTIPLIER was here
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage.rb:7: warning: already initialized constant Gitlab::Danger::Weightage::BASE_REVIEWER_WEIGHT
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage.rb:7: warning: previous definition of BASE_REVIEWER_WEIGHT was here
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage/reviewers.rb:22: warning: already initialized constant Gitlab::Danger::Weightage::Reviewers::DEFAULT_REVIEWER_WEIGHT
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage/reviewers.rb:22: warning: previous definition of DEFAULT_REVIEWER_WEIGHT was here
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage/reviewers.rb:23: warning: already initialized constant Gitlab::Danger::Weightage::Reviewers::TRAINTAINER_WEIGHT
/Users/albert/Dev/src/gitlab.com/gitlab-org/gdk/gitlab/lib/gitlab/danger/weightage/reviewers.rb:23: warning: previous definition of TRAINTAINER_WEIGHT was here
Loading development environment (Rails 6.0.3.4)
[1] pry(main)>

total_memory_used_by_dependencies_on_boot_prod_env_mb 771.7

After:

$ bundle exec rails c
--------------------------------------------------------------------------------
 Ruby:         ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
 GitLab:       13.8.0-pre (293f5a805b1) EE
 GitLab Shell: 13.15.0
 PostgreSQL:   11.9
--------------------------------------------------------------------------------
Loading development environment (Rails 6.0.3.4)
[1] pry(main)>

total_memory_used_by_dependencies_on_boot_prod_env_mb 758.7

part of #213954

Edited by Albert Salim

Merge request reports