Skip to content

Fix script typo in secret detection template causing detection to be skipped

What does this MR do?

Fixes #297475 (closed)

To address a script typo in the Secrets-Detection CI template from !51129 (merged):

Instead of:

if [[ $CI_COMMIT_TAG ]]; then ...; exit 0; fi

the template contained:

if [[ $CI_COMMIT_TAG ]]; ...; then exit 0; fi

(the then was in the wrong place, causing pipelines to skip detection in both cases where CI_COMMIT_TAG is defined and where CI_COMMIT_TAG is not defined)

Screenshots (strongly suggested)

Screen_Shot_2021-01-13_at_2.48.10_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports