Skip to content

MR Discussions API: document parameters "line_code" & "line_type"

What does this MR do?

The "line_range" parameter needlessly exposes implementation details (#247521 (closed)), and should probably be reworked. I started working on that, but I don't know when I can finish it, hence this patch to improve the documentation of the existing API.

I'd argue that most users are already happy when they can create notes on single lines. Me and others (#219215 (closed)) missed the fact that the "line_range" is optional. Make that very explicit.

The first commit cleans up bad API usage in a test I added in !47130 (merged).

Related issues

#247521 (closed), #219215 (closed)

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

For more information about labels, see Technical Writing workflows - Labels.

For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:

  • Clear typos, like this is a typpo.
  • Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.

For more information, see our documentation on Merging a merge request.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Johannes Altmanninger

Merge request reports