Skip to content

Add invite members link to comments [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Doug Stull requested to merge 296640-add-new-snowplow-events-for-mentions into master

What does this MR do?

  • Adds the Invite Member link to comments on merge request/issue show only.
  • Adds tracking for those events to support the experiment.

Note No changelog since it is behind a feature flag/experiment.

Test locally(GDK)

  • In rails console, enable the feature flag

      [2] pry(main)> Feature.enable(:invite_members_in_comment)
  • Go to any issue or MR where you are a maintainer or owner.

  • Use the invite member link in the comment toolbar as seen below.

Screenshots (strongly suggested)

Screen_Shot_2021-02-23_at_12.18.34_PM

Tracking validation

Comment Invite Shown

Screen_Shot_2021-03-12_at_10.21.44_AM

Comment Invite link clicked

Screen_Shot_2021-03-12_at_10.22.29_AM

Invite modal invite successful

Screen_Shot_2021-03-12_at_10.32.42_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296640

Edited by Doug Stull

Merge request reports