Skip to content

Fix halted migrations unpausing

Dmitry Gruzd requested to merge fix-halted-migrations-unpausing into master

What does this MR do?

During the issues migration rollout we noticed that for halted migration Elastic::MigrationWorker has been unpausing indexing each run, which could be dangerous and not expected by instance admins. This MR fixes this problem by introducing halted_indexing_unpaused flag, which is flipped only once after the migration is halted.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Dmitry Gruzd

Merge request reports