Remove license check from DAST.gitlab-ci.yml
What does this MR do?
As of gitlab-org/security-products/dast!360 (merged), the DAST analyze script errors displays an error and stops the scan when the user does not have the correct license to use DAST.
The MR removes the license checks from DAST.gitlab-ci.yml so that, rather than skipping the DAST job when the user isn't licensed is runs the jobs and shows an error instead, so that the user can take appropriate action to get the correct license.
However, the license check remains for when CI_KUBERNETES_ACTIVE is set since this is associated with AutoDevops usage. Users may be using Autodevops but not have a license that enables them to use DAST. In that case, the DAST job should not run.
This MR relates to #290958 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team