Skip to content

Detailed metrics modal: Fix modal footer

Lukas 'ai-pi' Eipert requested to merge 229675-fix-modal-footer into master

What does this MR do?

Detailed metrics modal: Fix modal footer

The modal for detailed metrics shouldn't have a footer with buttons, but because we use the wrong slot name, #footer instead of #modal-footer, we show OK and Cancel Buttons.

See: !46183 (merged)

Screenshots (strongly suggested)

Before After
Screenshot_2021-01-07_at_21.47.55 Screenshot_2021-01-07_at_21.47.24

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #229675 (closed)

Edited by Lukas 'ai-pi' Eipert

Merge request reports