Detailed metrics modal: Fix modal footer
What does this MR do?
Detailed metrics modal: Fix modal footer
The modal for detailed metrics shouldn't have a footer with buttons, but
because we use the wrong slot name, #footer
instead of
#modal-footer
, we show OK and Cancel Buttons.
See: !46183 (merged)
Screenshots (strongly suggested)
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #229675 (closed)
Edited by Lukas 'ai-pi' Eipert