Skip to content

Limit member tribute autocomplete to 10

Coung Ngo requested to merge cngo-limit-tribute-member-autocomplete into master

What does this MR do?

We currently use atjs for @ autocompletion, and we are in the process of migrating to tribute behind the feature flag :tribute_autocomplete since atjs is jQuery-based and deprecated. The migration is tracked in &4002.

When the tribute_autocomplete feature flag is switched on, we show all members in the @ autocomplete menu but since each menu item contains an avatar, a large number of fetches are done to get all these avatars. This commit limits the number of members listed in the autocomplete menu to avoid doing a large number of fetches.

Screenshots (strongly suggested)

before after
Screen_Recording_2021-01-08_at_1.52.38_pm Screen_Recording_2021-01-08_at_1.55.40_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports