Resolve "Newlines in custom server hook error messages render improperly in merge UI"
requested to merge KevSlashNull/gitlab:284640-fix-newline-in-custom-server-hook-renders-improperly into master
What does this MR do?
This MR fixes a bug where sending two errors in a custom server hook would show a <br>
to separate the two lines instead of an actual linebreak.
Related to #284640 (closed)
Pre-receive hook used
#!/bin/sh
echo "GL-HOOK-ERR: User is ${GL_ID}"
# HTML will be escaped (on the backend)
echo "GL-HOOK-ERR: Do better. <b>hi!</b>"
exit 1
Screenshots (strongly suggested)
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev