Skip to content

Migrate Bootstrap dropdown to GitLab UI GlDropdown in comment_form.vue

euko requested to merge remove-bootstrap-dropdowns-from-note-components into master

What does this MR do?

  • Replaces the deprecated dropdown used in 'comment_form.vue' with GitLab UI GlDropdown.

    'comment_form.vue' is used in issue, epic and merge request.

  • Updates the selectors used in the specs: 'comment_form_spec.js' and 'discussion_comments_shared_example.rb'.

    The shared examples under thread comments are split into two:

    thread comments for commit and snippet - this is exactly thread comments minus the parts that were only relevant to issue, epic and merge requests; e.g., !50933 (diffs).

    thread comments for issue, epic and merge request - identical to the original thread comments but has updated selectors

Completes #235366

Screenshots (strongly suggested)

location Before (Bootstrap) After (GitLab UI)
issue image image
* image image
* image image
epic Screen_Shot_2021-01-08_at_11.10.26_AM
merge request Screen_Shot_2021-01-08_at_11.11.09_AM
Screen_Shot_2021-01-11_at_1.44.48_PM
image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports