Skip to content

Display Terraform action errors to user

Emily Ring requested to merge terraform-state-errors into master

What does this MR do?

The current terraform table includes action buttons to lock/remove a state. These actions do not display any error information if the mutation fails.

Per our new design, error messages will need to appear inside the table.

We also have an upcoming issue, to add loading styles: #292713 (closed). It is likely the loading styles will also need to appear across the table row.

This MR will:

  • Move the Terraform State List to Vuex so custom loading and error fields can be added to each individual state
  • Move prop fields to Vuex
  • Add #row-details="row" template to the terraform table. This will display new error messages
  • Update tests and translations

Screenshots (strongly suggested)

errors

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Emily Ring

Merge request reports