Skip to content

Propagate remote_ip through ApplicationContext for API requests

Igor requested to merge gitaly-client-identity-3 into master

What does this MR do?

It was identified by @smcgivern in !49824 (comment 474695817) that we are missing propagation of remote_ip for API requests.

This patch aims to fix that.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

refs #232645 (closed)

Edited by Igor

Merge request reports