The source project of this merge request has been removed.
New partial for SSH Key Deletion
What does this MR do?
Creates a new, shared partial for SSH Key Deletion code that was similar in two files as mentioned in this issue.
- app/views/profiles/keys/_key_details.html.haml
- app/views/profiles/keys/_key.html.haml
- ee/app/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml
Screenshots
Screen_Recording_2021-01-20_at_10.00.57
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #267522
Edited by Robert Hunt