Skip to content

Feat(oncallschedules): add form validation - schedule / rotations

David O'Regan requested to merge 262857-validation into master

What does this MR do?

A small MVC where we add form validation for:

  • Add/Edit oncall schedule modals(name/timezone)
  • Add/Edit oncall schedule rotation modal(name, participants, start date)

🇺🇦 This feature is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀

To check Enable the feature flag:

  • Navigate to Operations => On-call Schedules or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules.
  • Click "Add schedule on empty state"
  • Add a schedule using the modal and see the validation in action
  • You will see a grid with an added schedule/rotation
  • Click edit schedule to see the validation in action
  • Use the add rotation button to view the add a rotation modal and see the validation in action

Screenshots (strongly suggested)

Screenshot_2020-12-12_at_12.44.04

Screenshot_2020-12-12_at_12.44.10

Screenshot_2020-12-12_at_12.44.14

Screenshot_2020-12-12_at_12.44.26

Screenshot_2020-12-12_at_12.44.31

Screenshot_2020-12-12_at_12.44.37

Screenshot_2020-12-12_at_12.44.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262860 (closed)

Edited by David O'Regan

Merge request reports