Feat(oncallschedules): add form validation - schedule / rotations
What does this MR do?
A small MVC where we add form validation for:
- Add/Edit oncall schedule modals(name/timezone)
- Add/Edit oncall schedule rotation modal(name, participants, start date)
oncall_schedules_mvc
and the minimal license is GitLab Premium
To check Enable the feature flag:
- Navigate to Operations => On-call Schedules or direct link is
your_project/-/oncall_schedules
e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules. - Click "Add schedule on empty state"
- Add a schedule using the modal and see the validation in action
- You will see a grid with an added schedule/rotation
- Click edit schedule to see the validation in action
- Use the add rotation button to view the add a rotation modal and see the validation in action
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #262860 (closed)
Edited by David O'Regan