Skip to content

Render EpicItemTimeline only once every row in Roadmap

euko requested to merge only-render-epic-item-timeline-once-every-row into master

What does this MR do?

This MR doesn't include any functional change.

  • Changes epic_item.vue (represents a row in Roadmap) to conditionally render EpicItemTimeline and CurrentDateIndicator once each, allowing us to avoid creating unnecessary vue instances:
before after
Screen_Shot_2020-12-30_at_12.58.02_PM
(each EpicItemTimeline has CurrentDateIndicator)
Screen_Shot_2020-12-30_at_12.57.28_PM

Screenshots (strongly suggested)

No visual change image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports