Remove security_on_demand_scans_site_validation FF [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

Removes the security_on_demand_scans_site_validation feature flag.

Post deployment todos

• Clean up the feature flag from all environments with /chatops run feature delete security_on_demand_scans_site_validation.
• Close the rollout issue #241815 (closed)

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #241815 (closed)