Skip to content

Introduce dismissal reason for vulnerability feedback

What does this MR do?

This MR introduces a new column called dismissal_reason for the vulnerability_feedback table and the respective enum for the Vulnerabilities::Feedback model.

Related to #293679 (closed)

Database Review

rake db:migrate

== 20201228184500 AddDismissalReasonIntoVulnerabilityFeedbackTable: migrating =
-- add_column(:vulnerability_feedback, :dismissal_reason, :smallint)
   -> 0.0038s
== 20201228184500 AddDismissalReasonIntoVulnerabilityFeedbackTable: migrated (0.0038s)

rake db:rollback

== 20201228184500 AddDismissalReasonIntoVulnerabilityFeedbackTable: reverting =
-- remove_column(:vulnerability_feedback, :dismissal_reason)
   -> 0.0024s
== 20201228184500 AddDismissalReasonIntoVulnerabilityFeedbackTable: reverted (0.0024s)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports