Change order of group export buttons
What does this MR do?
When exporting projects and groups from another GitLab instance, I noticed a confusing issue with the button order being inconsistent between the project export settings and the group export settings. When exporting many projects/groups this can become annoying, so I want to propose this small change.
This patch switches the buttons of the group export section, to be consistent with the order of the project export buttons. Also, the button text for the regenerate export button was changes to match the export project settings button.
As this is my first MR to GitLab, I am unsure about your workflow and I'd be happy to fix any issue that comes up with this MR.
Some things I am still unsure about:
- Do you want to change the button text at all?
- When renaming the button, is there any translation etc that is needed to be removed/updated?
- Should the QA identifiers etc also be updated to match the renamed button?
References to the current code sections
See project export: https://gitlab.com/gitlab-org/gitlab/-/blob/f2c10787791da337c834725c3b745c2545a4df2c/app/views/projects/_export.html.haml
And group export: https://gitlab.com/gitlab-org/gitlab/-/blob/f2c10787791da337c834725c3b745c2545a4df2c/app/views/groups/settings/_export.html.haml
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
This only changes the order of the buttons, so no further cross-browser tests should be needed.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done